Tweaks #1428
Tweaks #1428
Conversation
longhotsummer
commented
Aug 9, 2023
longhotsummer
commented
- fix judges in judgment table (I broke this a while ago :( )
- cache request language, this gets called a lot (reduces SQL queries)
- move labels below document title
for faceted pages, this can be called many times
| {# djlint:off #} | ||
| {{ bench.judge.name }}{% if not forloop.last %},{% endif %} | ||
| {# djlint:on #} | ||
| {% endfor %} | ||
| </td> |
There was a problem hiding this comment.
@longhotsummer I thought we removed these because some judgments have many judges which makes the table look a bit odd. Maybe we could limit the list to 3 or 4?
There was a problem hiding this comment.
Hmm, fair point. It's useful information for users to have, particularly those who know the judges.
Let's think it through in more detail, because a long list on mobile is particularly bad. Maybe we can do something like the first 3/4 and have "... and 3 more" or something.
There was a problem hiding this comment.
I agree. We'll need a better way of displaying long lists.
There was a problem hiding this comment.
I've removed this change based on feedback from the team that the judges aren't actually useful in the listing.
|
I've removed the judges column in the judgment table because (a) it's complex to get right on both wide and narrow displays, and (b) it's not critical information. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
