By-laws on LawLibrary #1432
By-laws on LawLibrary #1432
Conversation
nickmwangemi
commented
Aug 10, 2023
•
nickmwangemi
commented
nickmwangemi
force-pushed
the
bylaws-lawlibrary
branch
2 times, most recently
from
5be9387
to
1dbbb6d
Compare
nickmwangemi
force-pushed
the
bylaws-lawlibrary
branch
from
1dbbb6d
to
aef75d1
Compare
nickmwangemi
force-pushed
the
bylaws-lawlibrary
branch
2 times, most recently
from
439a38f
to
36efada
Compare
nickmwangemi
force-pushed
the
bylaws-lawlibrary
branch
from
36efada
to
be88c4e
Compare
| navbar_link = "legislation/municipal" | ||
|
|
||
| def get(self, *args, **kwargs): | ||
| self.municipality = get_object_or_404(Locality, code=kwargs["code"]) |
There was a problem hiding this comment.
Just a reminder that this is exactly what LocalityLegislationListView does, using the word locality rather than municipality. So this isn't necessary.
|
|
||
| class LocalityLegislationListView(LegislationListView): | ||
| template_name = "liiweb/locality_legislation_list.html" | ||
| navbar_link = "legislation/locality" | ||
| provincial_codes = PROVINCIAL_CODES |
There was a problem hiding this comment.
This can't be done in liiweb, because provinces are a lawlibrary thing only.
| def get_context_data(self, **kwargs): | ||
| context = super().get_context_data(**kwargs) | ||
| localities = Locality.objects.all() | ||
| context["province_groups"] = list(chunks(localities, 2)) |
There was a problem hiding this comment.
This needs to stay here, but rename province_groups to locality_groups.
| @@ -0,0 +1,36 @@ | |||
| {% if locality_type == "province" %} | |||
| <nav class="nav nav-tabs mb-3 border-bottom"> | |||
There was a problem hiding this comment.
The two if blocks are identical except for whether subleg is included. Rather remove the if block, and then pass in a flag from the View object to indicate whether the subleg should be shown.
| <a href="{% url 'locality_legislation_list' document.locality.code %}">{{ document.locality.name }}</a> | ||
| </li> | ||
| </ol> | ||
| {% if document.locality.code in PROVINCIAL_CODES %} |
There was a problem hiding this comment.
Only the first part of the breadcrumb changes, the rest is the same. So put the if block only around the part that changes, otherwise you're duplicating code.
