Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disclaimer in metadata #1571

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Disclaimer in metadata #1571

merged 1 commit into from
Oct 13, 2023

Conversation

actlikewill
Copy link
Contributor

image

closes #1502

@actlikewill actlikewill marked this pull request as ready for review October 12, 2023 08:34
@actlikewill
Copy link
Contributor Author

actlikewill commented Oct 12, 2023 •
edited
Loading

@goose-life how much text is in a disclaimer typically,? if its not too long this should be okay

@goose-life
Copy link
Contributor

@goose-life how much text is in a disclaimer typically,? if its not too long this should be okay

Here's a typical one used in Malawi:
"The publication date of this work could not be ascertained. We used the date 31 December 1963 because the work was published during the course of the year 1963."

@actlikewill
Copy link
Contributor Author

actlikewill commented Oct 12, 2023 •
edited
Loading

@goose-life For that kind of text, I think we could add the disclaimer as part of the notices:
image

longhotsummer
longhotsummer approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@longhotsummer longhotsummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@actlikewill actlikewill merged commit 28ba763 into main Oct 13, 2023
9 checks passed
@actlikewill actlikewill deleted the disclaimer branch October 13, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longhotsummer longhotsummer longhotsummer approved these changes

@goose-life goose-life goose-life approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a legislation user I want to see the disclaimer on a stub, too
3 participants
@actlikewill @goose-life @longhotsummer