In listing views, I want to see locality information if applicable #1692
Conversation
| @@ -4,8 +4,8 @@ | |||
| <thead> | |||
| <tr> | |||
| <th scope="col" style="width: 70%">{% trans 'Title' %}</th> | |||
| {% if doc_table_show_jurisdiction %} | |||
There was a problem hiding this comment.
What was the logic to determine the value of this variable previously?
There was a problem hiding this comment.
It's set only in africanlii to show the jurisdiction of taxonomies alone. But if we're showing jurisdiction across the site, I didn't think it'd matter.
There was a problem hiding this comment.
Agreed. Can you remove the logic that sets it in views.py or wherever?
| @@ -19,8 +19,12 @@ | |||
| <td> | |||
| <a href="{{ document.get_absolute_url }}">{{ document.title }}</a> | |||
| </td> | |||
| {% if doc_table_show_jurisdiction %} | |||
| <td>{% jurisdiction_icon document %} {{ document.jurisdiction }}</td> | |||
| {% if MULTIPLE_JURISDICTIONS and MULTIPLE_LOCALITIES %} | |||
There was a problem hiding this comment.
Not quite:
- if
MULTIPLE_JURISDICTIONS
a. show document.country
b. if document.locality, show it - elif
MULTIPLE_LOCALITIES
a. if document.locality, show it
There was a problem hiding this comment.
In the case of MULTIPLE_JURISDICTIONS, do you want the locality showing after the jurisdiction or before? Or should it be a separate column?
There was a problem hiding this comment.
Same column, but after. Separate with a https://en.wikipedia.org/wiki/Interpunct ·
eg. South Africa · Gauteng
There was a problem hiding this comment.
Is there a difference between if document.locality, show it and document.locality|default_if_none:''? Either way, a document without locality won't display anything
There was a problem hiding this comment.
Correct, no difference, except that you don't want the middot if there is no locality.
|
@longhotsummer back to you |
Closes #1646
Loom: https://www.loom.com/share/744292bf14c24d049528c369f1343583?sid=3217dbf5-1583-42f0-842c-8ec87785a200