Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross-origin popups #1693

Merged
merged 2 commits into from
Jan 22, 2024
Merged

cross-origin popups #1693

merged 2 commits into from
Jan 22, 2024

Conversation

longhotsummer
Copy link
Contributor

The idea here is that a user can hover over an FRBR URI link on, say, africanlii.org. It will try to fetch the popup for the link on africanlii.org. If AfricanLII doesn't have the document, it'll use the resolver to determine which LII does, and send a redirect to the popup on that LII. The browser follows the redirect and CORS permits the request.

Additionally, if it's a CORS/offsite request, then the popup includes the partner site's name.

image

@longhotsummer longhotsummer merged commit eaac02b into main Jan 22, 2024
9 checks passed
@longhotsummer longhotsummer deleted the cross-site-popups branch January 22, 2024 06:50
Copy link

sentry-io bot commented Jan 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ OperationalError: SSL connection has been closed unexpectedly /p/{partner}/e/popup/{frbr_uri} View Issue
  • ‼️ OperationalError: Timed-out waiting to acquire database connection. /p/{partner}/e/popup/{frbr_uri} View Issue
  • ‼️ InterfaceError: connection already closed /p/{partner}/e/popup/{frbr_uri} View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant