As an editor fixing mistakes, it would be useful to be able to temporarily unpublish a document rather than deleting it

[Sandravaphilips]

Closes #1688
https://www.loom.com/share/f81c6a462db9449ca867fda83ff2bd49?sid=fa93b543-0405-4817-829c-e5bade43d3ed

[longhotsummer]

This is a good start.

Most (all, I think) of our Listing views and our Detail views extend base classes within peachjam.views.generic_views. You should be able to add filter(published=True) there, rather than in every other type of view.

Check BaseDocumentDetailView.get_object and DocumentListView.get_base_queryset.

For DocumentListView, I think it's safer to add the filter in get_base_queryset (rather than changing queryset) because that method tries .queryset and .model.objects.

[Sandravaphilips]

@longhotsummer thanks for the feedback.
However, not all ListViews extend the base class, so I retained the ones that don't.
For the DetailView, I stuck with raising a 404 error in the DetailViewResolver instead. Implementing it in BaseDetailView raises a cannot find matching query error even when I say to raise the 404 error if the object is empty.

[longhotsummer]

Hmm, we need to do the same in all the HomePageView classes -- also search for recent_* and ensure those are corrected (mostly in homepage views I think).

[longhotsummer]

Great, much cleaner.

Just the homepage views, pls.

[longhotsummer]

Please also update peachjam_search.documents.SearchableDocument.should_index_object to skip unpublished documents.

I don't yet have a good recommendation for removing an unpublished doc from search, but we can leave that for now.