Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gazette improvements #1744

Merged
merged 24 commits into from
Mar 1, 2024
Merged

Gazette improvements #1744

merged 24 commits into from
Mar 1, 2024

Conversation

longhotsummer
Copy link
Contributor

@longhotsummer longhotsummer commented Feb 27, 2024

  • new ingestor adapter for fetching gazettes from the gazettes.laws.africa API
  • better locality and country-based gazette listings
  • fix regular tasks so that they aren't performed immediately after deployment
  • admins can set ingestor "last refreshed at" manually
  • don't override nature for gazettes
  • richer gazette model details
  • improved preconnects

https://www.loom.com/share/3045360fd14740978f4721e2394c9aee

@longhotsummer longhotsummer marked this pull request as ready for review February 28, 2024 12:45
@longhotsummer
Copy link
Contributor Author

Once this is merged, I'll run SQL to fill the new gazette fields from our master gazette database.

We'll then need to reconfigure the gazette ingestors to use the new API ingestor and remove the direct-to-database ingestor.

</li>
{% endif %}
<li class="breadcrumb-item active">{{ year }}</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the years list, the "All years" link isn't working properly, I think it should redirect to the main list page. The is a context variable "all_years_url" thats missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks

@longhotsummer
Copy link
Contributor Author

both issues fixed, thanks @actlikewill

actlikewill
actlikewill previously approved these changes Mar 1, 2024
Copy link
Contributor

@actlikewill actlikewill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. 👍

@longhotsummer longhotsummer merged commit ff6710b into main Mar 1, 2024
9 checks passed
@longhotsummer longhotsummer deleted the gazette-improvements branch March 1, 2024 09:07
Copy link

sentry-io bot commented Mar 3, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ InterfaceError: cursor already closed /gazettes View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants