Fix bulk importer updates #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
actlikewill
commented
Feb 28, 2024
actlikewill
commented
- This adds a method for calling the objects without defer in the fields for use in the importer
|
@longhotsummer I'm thinking maybe it would have been better to leave the original queryset untouched and then have a manager with something like |
actlikewill
commented
Feb 28, 2024
| @@ -246,6 +246,9 @@ def get_queryset(self): | |||
| # defer expensive fields | |||
| return super().get_queryset().defer("content_html", "toc_json") | |||
|
|
|||
| def get_qs_no_defer(self): | |||
| return super().get_queryset() | |||
|
|
|||
There was a problem hiding this comment.
@longhotsummer The change in the manager is necessary because Polymorphic doesn't like it when we do qs.defer(None)
longhotsummer
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.