Update source file details on file change #1760
Conversation
| def _save_m2m(self): | ||
| super()._save_m2m() | ||
| # update document text | ||
| self.instance.update_text_content() | ||
|
|
There was a problem hiding this comment.
@longhotsummer this is getting called before the source file is saved and updated so we can move it to after the save_related method
| if not self.filename: | ||
| self.filename = self.file.name | ||
| if not self.size: | ||
| self.size = self.file.size | ||
| if not self.mimetype: | ||
| self.file.seek(0) | ||
| self.mimetype = magic.from_buffer(self.file.read(), mime=True) |
There was a problem hiding this comment.
this prevents us from updating the source file details
There was a problem hiding this comment.
This messes with setting these fields explicitly. Instead, clear them in the admin form so that they get reset here.
peachjam/forms.py
Outdated
| if "file" in self.changed_data: | ||
| # clear all the fields that are derived from the file | ||
| for field in ["mimetype", "size", "file_as_pdf", "filename"]: | ||
| self.instance.__dict__[field] = None |
There was a problem hiding this comment.
setattr is the preferred method: setattr(self.instance, field, None)
There was a problem hiding this comment.
that is exactly what self.instance.field = None does
There was a problem hiding this comment.
or just do it explicitly: self.instance.mimetype = None etc. :)
peachjam/forms.py
Outdated
| def clean(self): | ||
| cleaned_data = super().clean() | ||
| if "file" in self.changed_data: | ||
| # clear all the fields that are derived from the file | ||
| for field in ["mimetype", "size", "file_as_pdf", "filename"]: | ||
| self.instance.__dict__[field] = None | ||
|
|
||
| return cleaned_data |
There was a problem hiding this comment.
@longhotsummer clearing the fields on the instance from the clean method allows us to compute them again on save.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This reverts commit 9e18d6b.
#1737