Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search tweaks #1761

Merged
merged 6 commits into from
Mar 6, 2024
Merged

Search tweaks #1761

merged 6 commits into from
Mar 6, 2024

Conversation

longhotsummer
Copy link
Contributor

@longhotsummer longhotsummer commented Mar 5, 2024 •
edited
Loading

https://www.loom.com/share/20aa50458330486fba39949b0981ea5f

  • always show advanced search tab when searching
  • streamline the layout; layout works on mobile
  • correctly restore exact phrase from url
  • support translations
  • simplify card layout
  • use select widget for AND/OR/NOT so we're not re-inventing the select widget
  • make AdvancedSearchFields responsible for managing the structure of its criterion, rather than firing multiple on-*-change handlers (Vue says you shouldn't manipulate a prop value, but actually it's perfectly safe)

image

@longhotsummer longhotsummer merged commit f1223ac into sandrava-1714 Mar 6, 2024
9 checks passed
@longhotsummer longhotsummer deleted the search-tweaks branch March 6, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sandravaphilips Sandravaphilips Awaiting requested review from Sandravaphilips

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@longhotsummer