Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When generating a TOC for HTML documents, don't generate entries for headings without text #1768

Merged
merged 1 commit into from
Mar 7, 2024
Merged

When generating a TOC for HTML documents, don't generate entries for headings without text #1768

merged 1 commit into from
Mar 7, 2024

Conversation

Sandravaphilips
Copy link
Collaborator

Closes #1736
Screenshot 2024-03-07 at 11 24 59
Screenshot 2024-03-07 at 11 32 46

@longhotsummer
Copy link
Contributor

Thanks - can you demo the case where there are headings, but interspersed with empty ones? eg:

<h1>parent</h1>
<h2>  </h2>
<h2>child</h2>

Also you must handle text that is whitespace.

@longhotsummer longhotsummer reopened this Mar 7, 2024
@Sandravaphilips
Copy link
Collaborator Author

@longhotsummer first h2 is empty, third one has whitespace. They both don't show up
Screenshot 2024-03-07 at 12 27 18

@Sandravaphilips Sandravaphilips merged commit 7e8669c into main Mar 7, 2024
13 checks passed
@Sandravaphilips Sandravaphilips deleted the sandrava-1736 branch March 7, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longhotsummer longhotsummer longhotsummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When generating a TOC for HTML documents, don't generate entries for headings without text
2 participants
@Sandravaphilips @longhotsummer