Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick search in judgment listing page #1802

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Quick search in judgment listing page #1802

merged 1 commit into from
Apr 24, 2024

Conversation

actlikewill
Copy link
Contributor

@actlikewill actlikewill commented Apr 22, 2024 •
edited
Loading

This adds quick search to the judgment listing page

image

closes #laws-africa/kenyalaw-pj#30

@actlikewill actlikewill marked this pull request as ready for review April 22, 2024 09:00
@longhotsummer
Copy link
Contributor

Does it include the query param to facet to the correct doc_type?

https://github.com/laws-africa/peachjam/blob/5387ac327068b2b6dc5fa2a3b26126934d179d55/peachjam/templates/peachjam/_quick_search.html#L15C47-L15C55

@actlikewill
Copy link
Contributor Author

@longhotsummer yes, the view includes the doctype in the context

peachjam/peachjam/views/judgment.py

Line 20 in 5387ac3

context["doc_type"] = "Judgment"

@longhotsummer longhotsummer self-requested a review April 23, 2024 06:10
@actlikewill actlikewill merged commit fdf507a into main Apr 24, 2024
9 checks passed
@actlikewill actlikewill deleted the judgement-search branch April 24, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longhotsummer longhotsummer longhotsummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@actlikewill @longhotsummer