Advanced search fixes #1813
Merged
Advanced search fixes #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for search__content, we must search: content, pages.body, and provisions.body
otherwise, we can't tell when to do a broad search vs an advanced search if we don't have explicit search fields
|
I've opened #1815 for the negative search issue |
actlikewill
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search__all; this means we can apply stricter match requirementsCloses #1795
https://www.loom.com/share/e0e891516fdd488cab852e9ca663c387
There is still a problem with negative queries on pages or legislation with provisions. Because each provision/page is indexed and search individually, it's possible to have a search
dog -catthat returns a document withcatin it, because it'll match pages or provisions that havedogbut notcat.So for negative searches we actually need to index and search the full content, not on a per-page or per-provision basis.