Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citations #1814

Merged
merged 4 commits into from
May 15, 2024
Merged

Citations #1814

merged 4 commits into from
May 15, 2024

Conversation

longhotsummer
Copy link
Contributor

https://www.loom.com/share/5ca9c3ec44ca45779abfaa9050977876

  • show citation counts in the citations tab
  • pre-calculate citation counts for works
  • group related documents by predicate

image

image

Comment on lines +172 to +175
# number of outgoing citations
n_cited_works = models.IntegerField(_("number of cited works"), default=0)
# number of incoming citations
n_citing_works = models.IntegerField(_("number of incoming citations"), default=0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was worried about this slowing down the pages with many citing documents but this solves that :)

Copy link
Contributor

@actlikewill actlikewill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I was considering splitting the citations tabs (outgoing and incoming) like we discussed as part of the KL improvements. We can discuss whether this is necessary.

@longhotsummer
Copy link
Contributor Author

Great. I was considering splitting the citations tabs (outgoing and incoming) like we discussed as part of the KL improvements. We can discuss whether this is necessary.

Yes, I think in future we probably will.

@longhotsummer longhotsummer merged commit c5e84e6 into main May 15, 2024
9 checks passed
@longhotsummer longhotsummer deleted the citations branch May 15, 2024 13:33
Copy link

sentry-io bot commented May 15, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ InterfaceError: connection already closed /{frbr_uri} View Issue
  • ‼️ InterfaceError: connection already closed /{frbr_uri} View Issue
  • ‼️ InterfaceError: connection already closed /{frbr_uri} View Issue
  • ‼️ InterfaceError: connection already closed /{frbr_uri} View Issue
  • ‼️ InterfaceError: connection already closed /{frbr_uri} View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants