Gazette volume number and resource #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peachjam/models/gazette.py
Outdated
| @@ -20,6 +20,7 @@ class Gazette(CoreDocument): | |||
| key = models.CharField( | |||
| _("key"), max_length=512, null=True, blank=True, db_index=True | |||
| ) | |||
| volume_number = models.IntegerField(_("volume number"), null=True, blank=True) | |||
|
Looks good. Do you think we should add it to the default gazette listing pages, near where we put the sub-publication or number? maybe in the same td? |
ah right. here it is, those are both sub_publication and volume number in the td |
longhotsummer
approved these changes
Jun 4, 2024
actlikewill
commented
Jun 4, 2024
Comment on lines
+1063
to
+1071
| fieldsets[0][1]["fields"].extend( | ||
| [ | ||
| "volume_number", | ||
| "sub_publication", | ||
| "supplement", | ||
| "supplement_number", | ||
| "publication", | ||
| ] | ||
| ) |
There was a problem hiding this comment.
added these to the admin as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the volume number and gazette bulk import resource
closes https://github.com/laws-africa/kenyalaw-pj/issues/76