Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore for 404 errors in adapter #1898

Closed
wants to merge 1 commit into from
Closed

Ignore for 404 errors in adapter #1898

wants to merge 1 commit into from

Conversation

actlikewill
Copy link
Contributor

@actlikewill actlikewill commented Jul 8, 2024 •
edited
Loading

Ignores 404 errors in indigo adapter

closes #1890

@actlikewill actlikewill marked this pull request as ready for review July 8, 2024 15:17
@longhotsummer
Copy link
Contributor

This is actually an interesting case because if the publication document URL is present, that URL should NOT 404. The same for downloading an image. I'm checking on the underlying data.

@longhotsummer
Copy link
Contributor

These two things should match but they don't:

image

@longhotsummer
Copy link
Contributor

I'd like to NOT implement this change, because it caught bad data. I've deleted the offending documents in indigo, and resolved the sentry issue.

@actlikewill
Copy link
Contributor Author

agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@actlikewill @longhotsummer