Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginated legislation listing #1901

Merged
merged 50 commits into from
Jul 18, 2024
Merged

Paginated legislation listing #1901

merged 50 commits into from
Jul 18, 2024

Conversation

actlikewill
Copy link
Contributor

image

peachjam/forms.py Outdated Show resolved Hide resolved
@longhotsummer longhotsummer marked this pull request as ready for review July 16, 2024 12:28
longhotsummer
longhotsummer previously approved these changes Jul 17, 2024
Copy link
Contributor

@longhotsummer longhotsummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

it seems that htmx throws an exception if two requests are in flight and
one request then tries to swap out content and the element to be
replaced is no longer in the tree

this way, the request is instead aborted; a log message is written to
the console, but no exception is thrown
@actlikewill actlikewill merged commit 84d7f32 into main Jul 18, 2024
9 checks passed
@actlikewill actlikewill deleted the listing branch July 18, 2024 07:52
actlikewill added a commit that referenced this pull request Jul 18, 2024
This reverts commit 84d7f32, reversing
changes made to b8f9e0d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants