Check for duplicates in taxonomy admin #1928
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug occurs when adding a dupilcate taxonomy from the admin.
Adding validation via
clean
on the model doesn't work as expected, because treebeard has some extra logic in thesave
method inMoveNodeForm
. it ends up overriding the native behaviour that catches validation errors thrown from the model. Having the logic on the form works better, with some extra work to get the appropriate parent to validate the slug.closes #1915