fix alphabet filter #1942
Merged
fix alphabet filter #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@longhotsummer I'm now thinkinig that the main reason we had that bug was because we were using the params directly without cleaning, so using the cleaned_data fixed the original bug, CharField cleans the nulls |
longhotsummer
previously approved these changes
Jul 29, 2024
longhotsummer
previously approved these changes
Jul 29, 2024
|
Please sanity check this works for |
it works okay. the CharField cleans up the nulls |
longhotsummer
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typed multiple choice field returns a list.