Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust build workflow to limit unnecessary changes to js #1947

Merged
merged 9 commits into from
Aug 1, 2024

Conversation

longhotsummer
Copy link
Contributor

@longhotsummer longhotsummer commented Jul 31, 2024

the sentry webpack plugin always updates compiled js by adding a sentry debug and release id. This means that the file changes every time we merge into this branch (and then deploy), which duplicates deployments and means our users are forced to re-download JS that hasn't actually cached.

So, we now:

  1. run webpack
  2. strip the sentry stuff from the newly compiled code AND a copy in git at HEAD
  3. diff those two versions
  4. only commit the compiled javascript if the stripped versions differ

longhotsummer and others added 9 commits July 31, 2024 16:39
the sentry webpack plugin always updates compiled js by adding a sentry
debug and release id. This means that the file changes every time we
merge into this branch (and then deploy), which duplicates deployments
and means our users are forced to re-download JS that hasn't actually
cached.
@longhotsummer longhotsummer marked this pull request as ready for review July 31, 2024 15:01
Copy link
Contributor

@actlikewill actlikewill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting

@longhotsummer longhotsummer merged commit 8f94a3c into main Aug 1, 2024
8 checks passed
@longhotsummer longhotsummer deleted the js-build branch August 1, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants