-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility improvements #1948
Conversation
@longhotsummer @niiroobiro I've linked a small loom for this pr above |
This looks great. The updated colour choices make sense. The visited colour for lawlibrary isn't the right shade now that the primary colour has changed. The visited link colour would be better to be declared as a SCSS variable in |
@actlikewill I love the colour changes. Consider adding IDs to "Recent Judgments","Recent legislation" and "Gazettes" This will give users the flexibility to navigate directly to sections that are most relevant to them. Especially when you are using a screen reader. |
@niiroobiro I was strongly considering this, but at the same time, I'm wary of adding too many links at in the skip links section. They should be few brief in order to be useful, to allow the user to quickly jump to the part of the page they are interested in. Lets wait a bit and we can come back to this when, we do some more focused accessibility stuff. |
https://www.loom.com/share/20931ea7ccd944ff86b850482c20ce50?sid=510213df-d4ce-407d-beca-fc78fb23d294
closes https://github.com/laws-africa/kenyalaw-pj/issues/63