Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility improvements #1948

Merged
merged 9 commits into from
Aug 14, 2024
Merged

Accessibility improvements #1948

merged 9 commits into from
Aug 14, 2024

Conversation

@actlikewill
Copy link
Contributor Author

@longhotsummer @niiroobiro I've linked a small loom for this pr above

@actlikewill actlikewill marked this pull request as ready for review August 13, 2024 08:59
@longhotsummer
Copy link
Contributor

This looks great. The updated colour choices make sense.

The visited colour for lawlibrary isn't the right shade now that the primary colour has changed.

The visited link colour would be better to be declared as a SCSS variable in variables.scss near where the primary colour is declared, so that they're nearby to each other.

@niiroobiro
Copy link
Contributor

@actlikewill I love the colour changes. Consider adding IDs to "Recent Judgments","Recent legislation" and "Gazettes" This will give users the flexibility to navigate directly to sections that are most relevant to them. Especially when you are using a screen reader.

@actlikewill
Copy link
Contributor Author

@actlikewill I love the colour changes. Consider adding IDs to "Recent Judgments","Recent legislation" and "Gazettes" This will give users the flexibility to navigate directly to sections that are most relevant to them. Especially when you are using a screen reader.

@niiroobiro I was strongly considering this, but at the same time, I'm wary of adding too many links at in the skip links section. They should be few brief in order to be useful, to allow the user to quickly jump to the part of the page they are interested in. Lets wait a bit and we can come back to this when, we do some more focused accessibility stuff.

@actlikewill actlikewill merged commit 18320e9 into main Aug 14, 2024
8 checks passed
@actlikewill actlikewill deleted the a11y branch August 14, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants