Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locality filters for Lawlibrary #2008

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Fix locality filters for Lawlibrary #2008

merged 1 commit into from
Sep 9, 2024

Conversation

actlikewill
Copy link
Contributor

This fixes the base view that is used for the national legislation listing views.
The base view should filter out documents that have localites

closes #1979

Copy link

github-actions bot commented Sep 9, 2024

Test Results

2 tests   - 46   2 ✅  - 46   0s ⏱️ -12s
1 suites  - 12   0 💤 ± 0 
1 files    - 12   0 ❌ ± 0 

Results for commit 8c6f051. ± Comparison against base commit 2392f2a.

This pull request removes 48 and adds 2 tests. Note that renamed tests count towards both.
peachjam.tests.test_admin.TestJudgmentAdmin ‑ test_add_judgment_docx_swap_pdf
peachjam.tests.test_admin.TestJudgmentAdmin ‑ test_add_judgment_pdf_swap_docx
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_case_number_import_without_matter_type
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_case_numbers_with_matter_type
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_import_with_taxonomy
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_judgment_bulk_import
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_source_file_prefers_docx_over_pdf
peachjam.tests.test_citations.CitationAnalyserTestCase ‑ test_delete_citations
peachjam.tests.test_citations.CitationAnalyserTestCase ‑ test_delete_citations_should_not_change_akn
peachjam.tests.test_citations.CitationAnalyserTestCase ‑ test_pdf_extractions
…
liiweb.tests.test_mnc_matcher.MncMatcherTest ‑ test_html_matches
liiweb.tests.test_mnc_matcher.MncMatcherTest ‑ test_za_provincial_matches

Copy link

github-actions bot commented Sep 9, 2024

Test Results

1 tests   - 47   1 ✅  - 47   0s ⏱️ -13s
1 suites  - 12   0 💤 ± 0 
1 files    - 12   0 ❌ ± 0 

Results for commit 8c6f051. ± Comparison against base commit 5d9aa1f.

This pull request removes 48 and adds 1 tests. Note that renamed tests count towards both.
peachjam.tests.test_admin.TestJudgmentAdmin ‑ test_add_judgment_docx_swap_pdf
peachjam.tests.test_admin.TestJudgmentAdmin ‑ test_add_judgment_pdf_swap_docx
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_case_number_import_without_matter_type
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_case_numbers_with_matter_type
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_import_with_taxonomy
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_judgment_bulk_import
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_source_file_prefers_docx_over_pdf
peachjam.tests.test_citations.CitationAnalyserTestCase ‑ test_delete_citations
peachjam.tests.test_citations.CitationAnalyserTestCase ‑ test_delete_citations_should_not_change_akn
peachjam.tests.test_citations.CitationAnalyserTestCase ‑ test_pdf_extractions
…
africanlii.tests.test_views.AfricanliiViewsTest ‑ test_homepage

♻️ This comment has been updated with latest results.

@actlikewill actlikewill marked this pull request as ready for review September 9, 2024 08:27
Copy link
Contributor

@longhotsummer longhotsummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sneaky bug

@actlikewill
Copy link
Contributor Author

maybe we should consider supporting the locality vs national setup from peachjam itself,

@actlikewill actlikewill merged commit 990a41b into main Sep 9, 2024
9 checks passed
@actlikewill actlikewill deleted the uncommenced branch September 9, 2024 08:31
@longhotsummer
Copy link
Contributor

maybe we should consider supporting the locality vs national setup from peachjam itself,

Yes, ultimately we should. We can do that when the second LII with local legislation comes online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncommenced national legislation view is erroneously including local legislation
2 participants