Add convert html to judgment #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results50 tests +48 50 ✅ +48 11s ⏱️ +11s Results for commit babc4d3. ± Comparison against base commit 8506c15. This pull request removes 2 and adds 50 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
peachjam/models/judgment.py
Outdated
| @@ -441,6 +445,22 @@ def pre_save(self): | |||
| self.assign_title() | |||
| super().pre_save() | |||
|
|
|||
| def convert_html_to_pdf(self): | |||
| with NamedTemporaryFile(suffix=".html") as html_file: | |||
| html_file.write(self.content_html.encode("utf-8")) | |||
There was a problem hiding this comment.
I suggest you do something like html_file.write(self.prepare_content_html_for_pdf()) so that subclasses can override the HTML that is used to generate the PDF, such as by adding a logo at the top.
Also, I think this can safely all be done on the CoreDocument object.
peachjam/tasks.py
Outdated
| @@ -206,6 +206,19 @@ def convert_source_file_to_pdf(source_file_id): | |||
| log.info("Conversion to PDF done") | |||
|
|
|||
|
|
|||
| @background(queue="peachjam", remove_existing_tasks=True) | |||
| def convert_html_to_pdf(judgment_id): | |||
| from peachjam.models import Judgment | |||
There was a problem hiding this comment.
I think this should work for any file, not just judgment.
longhotsummer
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the convert html to pdf method to the judgment model