Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments url should support alphanumeric slug #2066

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

actlikewill
Copy link
Contributor

@actlikewill actlikewill commented Sep 27, 2024

some models eg country in countries_plus have letters in the pk
https://lawsafrica.sentry.io/issues/5914901445/events/0fb1e238b89f43ecb51e8b6b1bfb2d72/

@actlikewill actlikewill marked this pull request as ready for review September 27, 2024 05:54
Copy link

Test Results

2 tests  +1   2 ✅ +1   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit d719e32. ± Comparison against base commit ee7177f.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
africanlii.tests.test_views.AfricanliiViewsTest ‑ test_homepage
liiweb.tests.test_mnc_matcher.MncMatcherTest ‑ test_html_matches
liiweb.tests.test_mnc_matcher.MncMatcherTest ‑ test_za_provincial_matches

Copy link

github-actions bot commented Sep 27, 2024

Test Results

50 tests  +49   50 ✅ +49   10s ⏱️ +10s
13 suites +12    0 💤 ± 0 
13 files   +12    0 ❌ ± 0 

Results for commit d719e32. ± Comparison against base commit ee7177f.

This pull request removes 1 and adds 50 tests. Note that renamed tests count towards both.
africanlii.tests.test_views.AfricanliiViewsTest ‑ test_homepage
peachjam.tests.test_admin.TestJudgmentAdmin ‑ test_add_judgment_docx_swap_pdf
peachjam.tests.test_admin.TestJudgmentAdmin ‑ test_add_judgment_pdf_swap_docx
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_case_number_import_without_matter_type
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_case_numbers_with_matter_type
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_import_with_taxonomy
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_judgment_bulk_import
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_source_file_prefers_docx_over_pdf
peachjam.tests.test_citations.CitationAnalyserTestCase ‑ test_delete_citations
peachjam.tests.test_citations.CitationAnalyserTestCase ‑ test_delete_citations_should_not_change_akn
peachjam.tests.test_citations.CitationAnalyserTestCase ‑ test_pdf_extractions
…

♻️ This comment has been updated with latest results.

@actlikewill actlikewill merged commit 62e67ad into main Sep 27, 2024
9 checks passed
@actlikewill actlikewill deleted the comment-url branch September 27, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants