Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for duplicate images in adapter #2080

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Check for duplicate images in adapter #2080

merged 1 commit into from
Sep 30, 2024

Conversation

actlikewill
Copy link
Contributor

check for duplicate image

@actlikewill actlikewill marked this pull request as ready for review September 30, 2024 10:19
@github-actions GitHub Actions
Copy link

Test Results

1 tests   - 49   1 ✅  - 49   0s ⏱️ -11s
1 suites  - 12   0 💤 ± 0 
1 files    - 12   0 ❌ ± 0 

Results for commit 4f2f951. ± Comparison against base commit 3348183.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

Test Results

50 tests  ±0   50 ✅ ±0   12s ⏱️ -1s
13 suites ±0    0 💤 ±0 
13 files   ±0    0 ❌ ±0 

Results for commit 4f2f951. ± Comparison against base commit 3348183.

♻️ This comment has been updated with latest results.

@longhotsummer
Copy link
Contributor

the filenames set already does this?

@longhotsummer
Copy link
Contributor

#2065 already fixed this in theory?

longhotsummer
longhotsummer approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@longhotsummer longhotsummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to include this to make it more robust

@actlikewill actlikewill merged commit 3da4c38 into main Sep 30, 2024
9 checks passed
@actlikewill actlikewill deleted the img-dup branch September 30, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longhotsummer longhotsummer longhotsummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@actlikewill @longhotsummer