Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order subsidiary legislation by frbr_uri number #2087

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

actlikewill
Copy link
Contributor

@actlikewill actlikewill commented Oct 3, 2024

  • This adds the frbr uri number as a secondary sort parameter for subleg
  • The ordering needs to be reversed if the order date sorting is reversed

image

closes https://github.com/laws-africa/kenyalaw-pj/issues/115

Copy link

github-actions bot commented Oct 3, 2024

Test Results

50 tests  +50   50 ✅ +50   12s ⏱️ +12s
13 suites +13    0 💤 ± 0 
13 files   +13    0 ❌ ± 0 

Results for commit c94beb6. ± Comparison against base commit c3a7f40.

♻️ This comment has been updated with latest results.

@actlikewill
Copy link
Contributor Author

@longhotsummer this is still less than perfect, because we sort primarily by date. First some amendments from earlier years can show up in the current year. Second, some of them are not releaseed chronologically eg. in the screenshot, legal notices 63 and 64 have a date earlier than 55, and the rest following which puts them out of order

@actlikewill actlikewill marked this pull request as ready for review October 4, 2024 06:40
@longhotsummer
Copy link
Contributor

I think this is a reasonable start, particularly for recent legislation.

@actlikewill actlikewill merged commit aefc78a into main Oct 4, 2024
9 checks passed
@actlikewill actlikewill deleted the order-leg branch October 4, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants