Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: footer container breaking in some break points #313

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

upsaurav12
Copy link
Contributor

Notes for Reviewers

This PR fixes #286
In I have fixed some issues like company container was breaking at some points such as 850px and <=400px so i have fixed them .
Here are some Results for 850px

Prev
image
After
image

Here are some Results for <=400px

Before
image

After
image

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit b87d2ab
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/6685861aac241f00089c7c06
😎 Deploy Preview https://deploy-preview-313--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@leecalcote leecalcote requested a review from 35C4n0r July 3, 2024 04:16
@iArchitSharma
Copy link
Contributor

iArchitSharma commented Jul 3, 2024

@upsaurav12 Before looks much better than the After

@iArchitSharma
Copy link
Contributor

@upsaurav12 please keep the alignment to the left instead of center

@upsaurav12
Copy link
Contributor Author

upsaurav12 commented Jul 3, 2024

@iArchitSharma will do it but rest of it any other suggestion for improvement?
My idea was to utilizr the extra space that was left in right side of the container
also
image
company container should be after Solutions

@iArchitSharma
Copy link
Contributor

@iArchitSharma will do it but rest of it any other suggestion for improvement? My idea was to utilizr the extra space that was left in right side of the container also image company container should be after Solutions

LGTM now, thanks @upsaurav12

@iArchitSharma iArchitSharma merged commit 111d864 into layer5io:master Jul 3, 2024
6 checks passed
@upsaurav12
Copy link
Contributor Author

Thanks @iArchitSharma First merged PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Improvement in footer when width is smaller
2 participants