Skip to content

Fix: Set Transparent Background for Kanvas Logo (#588) #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ayushmore1214
Copy link

This PR resolves Issue #588 by ensuring the Kanvas logo has a transparent background, rather than displaying with an unintended black background.

🔧 What’s Changed
Added a CSS rule to _styles_project.scss to apply background-color: transparent to image elements like .img-thumbnail and .td-content img.

This ensures all SVGs and other images render with proper transparent backgrounds across the site.

Notes for Reviewers

This PR fixes #588

Before :
https://i.postimg.cc/h43YHBWW/449377089-28df93af-a82b-41c8-875f-99f1488d1fcf.png

After :
https://i.postimg.cc/mkcmbPfx/Screenshot-213.png

Signed commits

  • Yes, I signed my commits.

This PR resolves Issue layer5io#588 by ensuring the Kanvas logo has a transparent background, rather than displaying with an unintended black background.

🔧 What’s Changed
Added a CSS rule to _styles_project.scss to apply background-color: transparent to image elements like .img-thumbnail and .td-content img.

This ensures all SVGs and other images render with proper transparent backgrounds across the site.



Signed-off-by: Ayush More <[email protected]>
Copy link

netlify bot commented Jun 11, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 2f47381
🔍 Latest deploy log https://app.netlify.com/projects/bejewelled-pegasus-b0ce81/deploys/6849a58f70c1e30008b55b4e
😎 Deploy Preview https://deploy-preview-602--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Ayushmore1214
Copy link
Author

@leecalcote please take review on this issues and let me know if there any problems

@leecalcote leecalcote requested a review from M-DEV-1 June 11, 2025 15:54
@M-DEV-1
Copy link
Member

M-DEV-1 commented Jun 11, 2025

@Ayushmore1214 before we proceed, have you identified why it only affected the Kanvas SVG, and not the Layer5 SVG?

@Ayushmore1214
Copy link
Author

Thank you for the question, @M-DEV-1!

Yes, I investigated why the issue only appeared with the Kanvas SVG and not the Layer5 SVG.

Root Cause:
The Kanvas SVG didn't explicitly declare a transparent background, and due to the site-wide CSS or default rendering behavior (especially in dark mode), it inherited a black background when no background-color was specified.
Meanwhile, the Layer5 SVG was either already embedded in a container with explicit transparency or was saved/exported in a way that avoided the fallback background.

🛠 Fix Explanation:
Instead of editing the SVG file directly (which might not be scalable if others face similar issues), I added a global CSS rule in _styles_project.scss targeting:

.img-thumbnail, .td-content img {
background-color: transparent;
}
This ensures consistent transparent rendering across all such images, including the Kanvas logo — without impacting Layer5 SVG or any other visuals negatively.

@Ayushmore1214
Copy link
Author

If there is anything to improve let me know ! @M-DEV-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Kanvas Logo Background Color
2 participants