-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Update setup prerequisite card css #679
Conversation
Signed-off-by: Rudraksh Tyagi <[email protected]>
Signed-off-by: Rudraksh Tyagi <[email protected]>
Thank you! Clarification: this means that if only two cards are present, they will split the landscape 50/50, right? And if only one is present, it will consume 100% of the width, right? @dragon-slayer875 |
Yes sir. Exactly that. |
@@ -22,10 +22,10 @@ const ContainerCardWrapper = styled('div')(({ theme }) => ({ | |||
})); | |||
|
|||
const Card = styled('a')(({ theme }) => ({ | |||
flex: '1', | |||
padding: '2rem', | |||
textDecoration: 'none', | |||
background: theme.palette.mode === 'light' ? '#EEEEEE' : '#212121', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this is hard coded colors🤔?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Notes for Reviewers
This PR updates the SetupPreReq Card component's CSS to have
![image](https://private-user-images.githubusercontent.com/59254790/348476047-051ad5b5-2a6f-4026-a470-de6ea3400115.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxMDY2NjksIm5iZiI6MTcyNDEwNjM2OSwicGF0aCI6Ii81OTI1NDc5MC8zNDg0NzYwNDctMDUxYWQ1YjUtMmE2Zi00MDI2LWE0NzAtZGU2ZWEzNDAwMTE1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE5VDIyMjYwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ0MmIwMWVkMWNmNWNhOTUyNWM4OTQ3ZGIzYzY5ZGQwNmE1OTE3MzhmZGRlZThhMzA3ZjlmNGM4YmYyZDYxOWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.zwzR5hJG87Ot5RrRvA6yApFLOwZrXElVY9gLzkC_WsU)
flex: 1
property.Signed commits