[chore] Update setup prerequisite card css #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rudraksh Tyagi <[email protected]>
dragon-slayer875
requested review from
leecalcote
and removed request for
leecalcote
Signed-off-by: Rudraksh Tyagi <[email protected]>
|
Thank you! Clarification: this means that if only two cards are present, they will split the landscape 50/50, right? And if only one is present, it will consume 100% of the width, right? @dragon-slayer875 |
|
Yes sir. Exactly that. |
| @@ -22,10 +22,10 @@ const ContainerCardWrapper = styled('div')(({ theme }) => ({ | |||
| })); | |||
|
|
|||
| const Card = styled('a')(({ theme }) => ({ | |||
| flex: '1', | |||
| padding: '2rem', | |||
| textDecoration: 'none', | |||
| background: theme.palette.mode === 'light' ? '#EEEEEE' : '#212121', | |||
There was a problem hiding this comment.
why this is hard coded colors🤔?
There was a problem hiding this comment.
I think Akshay did it because the palette colors were lighter than he required.
This is theme.palette.background.surfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR updates the SetupPreReq Card component's CSS to have
flex: 1property.Signed commits