Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI]: add a version tag to CatalogCard component #691

Closed
wants to merge 7 commits into from

Conversation

SAHU-01
Copy link

@SAHU-01 SAHU-01 commented Jul 24, 2024

Notes for Reviewers

This PR fixes #688

Signed commits

  • Yes, I signed my commits.

position: 'absolute',
top: '40px',
right: '8px',
backgroundColor: theme.palette.primary.main,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use color from palette @SAHU-01

position: 'absolute',
bottom: '65px',
left: '18px',
backgroundColor: theme.palette.grey[500],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not these, there is tokens we use you will get those in palette.js file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not these, there is tokens we use you will get those in palette.js file.

Thank you for sharing this, I'll make sure to take a look at it and modify this.

@sudhanshutech
Copy link
Member

@dottharun

@SAHU-01
Copy link
Author

SAHU-01 commented Aug 2, 2024

@sudhanshutech based on the Wednesday call feedback that I received, I need to add the flipable thingy and also centralize the catalog card and add on flip all the details that were available on meshery cloud. I'll be done with this over the weekend and will make sure to notify you.

@sudhanshutech
Copy link
Member

sudhanshutech commented Aug 2, 2024

oh its good. I was tagging @dottharun to confirm does he has any things to confirm here?

@dottharun
Copy link
Contributor

@SAHU-01 Does this support dark mode, and can you provide screenshots if you can?

@SAHU-01
Copy link
Author

SAHU-01 commented Aug 2, 2024

@dottharun the tag color doesn't change with dark or light mode switch as of now if you want me to enable that, do let me know
image
image

@dottharun
Copy link
Contributor

@SAHU-01 Yes, please use the same shades as the footer.

@SAHU-01
Copy link
Author

SAHU-01 commented Aug 5, 2024

@dottharun I did add the version background based on the color palette used for metrics container and it looks something like this:
for dark theme:
image
for light theme:
image

@SAHU-01
Copy link
Author

SAHU-01 commented Aug 5, 2024

@sudhanshutech, I have a couple of questions here:

  1. should I move all styled components like this to src>custom>CatalogCard>style.css:
const BackFaceContent = styled(Box)(({ theme }) => ({
  position: 'absolute',
  background: `linear-gradient(to bottom right, black 40%, ${theme.palette.background.brand?.default})`,
  width: '100%',
  top: 0,
  left: 0,
  display: 'flex',
  flexDirection: 'column',
  alignItems: 'left',
  padding: '16px',
  boxShadow: `2px 2px 3px 0px black`,
  borderRadius: '1rem'
}));
  1. As discussed earlier for lining issues I've added a new interface do let em know if that requires changes.
  2. @dottharun had suggested adding version background based on the color palette used for metrics container please take a look at it and let me know if that suits or we could opt for a different color palette
  3. The linear gradient is not similar to the one on Catalog Page I was unable to find a figma for the flip catalog card, do let me know if that needs to be changed, I would need the exact hex codes though.

@SAHU-01
Copy link
Author

SAHU-01 commented Aug 5, 2024

Please find the demo screen here:

Screen.Recording.2024-08-05.at.12.03.27.PM.mov

@sudhanshutech
Copy link
Member

@SAHU-01 yes the styles should be in separate style folder

@dottharun
Copy link
Contributor

@SAHU-01 If we are using the flip card and showing the version only on the backside, just use the same shades as in https://meshery.layer5.io/.

@sudhanshutech
Copy link
Member

any more help needed @SAHU-01 ?

@SAHU-01
Copy link
Author

SAHU-01 commented Aug 6, 2024

@sudhanshutech yes, the figma design? Does the gradient and padding look good to you in the recording? If yes I'll push the style file and tag theme changes now?

@sudhanshutech
Copy link
Member

the color of metrics in from of card could be shade of white for dark mode. See which looks good from using the token.

@sudhanshutech
Copy link
Member

@SAHU-01 have gone through the card here in cloud,: https://meshery.layer5.io/catalog?

@sudhanshutech
Copy link
Member

@dottharun @vishalvivekm @captain-Akshay do we have figma design for this card?

@SAHU-01
Copy link
Author

SAHU-01 commented Aug 12, 2024

@dottharun, I've removed the flip logic from this PR and I've added the versionTag and the versionTagPosition props with proper styling as per your suggestion.
@sudhanshutech I'll be sending the other PR with centralized sistent logic soon.
Currently this is how it looks:

Screen.Recording.2024-08-12.at.5.20.34.PM.mov

@SAHU-01 SAHU-01 closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Centralizing the CatalogCard component in sistent
3 participants