feat: add secret for java sdk #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeflood
requested changes
Sep 26, 2022
|
@fft0518 it has method to get |
ZLBer
reviewed
Sep 27, 2022
examples-secret/src/main/java/io/mosn/layotto/examples/secret/Secret.java
Outdated
Show resolved
Hide resolved
|
@fft0518 add a java example? like examples-sequencer |
|
@fft0518 merge the master branch before push code |
|
ZLBer
reviewed
Sep 27, 2022
sdk/src/main/java/spec/sdk/runtime/v1/domain/secret/GetBulkSecretResponse.java
Outdated
Show resolved
Hide resolved
ZLBer
previously approved these changes
Sep 27, 2022
|
@seeflood please help to review it. Thanks. |
seeflood
requested changes
Sep 28, 2022
seeflood
requested changes
Sep 28, 2022
seeflood
requested changes
Sep 28, 2022
examples-secret/src/main/java/io/mosn/layotto/examples/secret/Secret.java
Outdated
Show resolved
Hide resolved
seeflood
requested changes
Sep 28, 2022
examples-secret/src/main/java/io/mosn/layotto/examples/secret/Secret.java
Outdated
Show resolved
Hide resolved
seeflood
requested changes
Sep 28, 2022
sdk/src/main/java/spec/sdk/runtime/v1/domain/secret/GetBulkSecretRequest.java
Outdated
Show resolved
Hide resolved
seeflood
requested changes
Sep 28, 2022
seeflood
requested changes
Sep 28, 2022
seeflood
requested changes
Sep 28, 2022
examples-secret/src/main/java/io/mosn/layotto/examples/secret/Secret.java
Show resolved
Hide resolved
seeflood
requested changes
Sep 28, 2022
Signed-off-by: seeflood <[email protected]>
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is add secret api for java sdk and is one of the ospp projects.
In this PR, I have a problem that I don't how to convert SecretResponse type to Map type. I also use the SecretResponse type although I think it's wrong.
mosn/layotto#626