fix: can start multi times

layotto · Aug 23, 2023 · 76ba3c0 · 76ba3c0
1 parent c32523b
commit 76ba3c0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/server/Server.ts b/src/server/Server.ts
@@ -35,6 +35,7 @@ export default class Server {
   protected readonly logger: Console;
   private readonly _serverImpl: GRPCServerImpl;
   private readonly _server: GRPCServer;
+  #start = false;
 
   constructor(port: string = process.env.appcallback_GRPC_PORT ?? '9999',
     GRPCServerInstance?: any,
@@ -54,9 +55,10 @@ export default class Server {
   }
 
   async start(): Promise<void> {
+    if (this.#start) return;
+    this.#start = true;
     await this._bind();
     this._server.start();
-    await sleep(250);
   }
 
   async close(): Promise<void> {

diff --git a/test/unit/server/GRPCServerImpl.test.ts b/test/unit/server/GRPCServerImpl.test.ts
@@ -65,6 +65,8 @@ describe.skip('server/GRPCServerImpl.test.ts', () => {
     const serverImpl = new CustomGRPCServerImpl(pubsubConfig);
     server = new Server('9999', serverImpl);
     await server.start();
+    // start multi times should work
+    await server.start();
   });
 
   afterAll(async () => {