Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: test:lock script #13

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: test:lock script #13

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4600801
feat:add Run lock API quickstart with js sdk - demo
LZHK1ng Jul 5, 2022
8a261f1
fix:node package
LZHK1ng Jul 6, 2022
2b68e6a
add test:lock script
LZHK1ng Oct 19, 2022
bcbe8f6
Merge branch 'layotto:main' into main
LZHK1ng Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"test": "jest --detectOpenHandles",
"test:unit": "NODE_ENV=test npm run test 'test/unit/.*\\.test\\.ts'",
"test:demo": "cd demo && npm run test:all",
"test:lock": "cd demo && npm run test:lock",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I still failed in my local machine.

cd js-sdk/demo
npm install

The error message:
image

Copy link
Contributor Author

@LZHK1ng LZHK1ng Oct 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you can try it
cd js-sdk
npm install

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LZHK1ng Then npm install succeeds but npm run test:lock fails:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, The original approach worked in my machine.But it failed in CI😢.I try to use yarn install to fix it.
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still failed on my laptop:

cd demo
yarn install

image

"lint": "tslint -p tsconfig.json",
"build:grpc": "scripts/build-grpc.sh",
"tsc:clean": "rm -rf dist",
Expand Down