This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… checks whether they are alive before contacting
Can you integrate the changes into start.js? That way, when a user downloads the repo and starts up the program with start.js, audits will work way they do in your demo Especially since the global batnode.js file is updated to reflect the new feature(s) you added, it would be good for the global start script to follow suit |
floalex
approved these changes
Mar 30, 2018
Yeah, good catch that wasn't intentional. I added the logic to the start script as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a rough branch, but still wanted to put it out there if others had thoughts.
batchain
terminal window for the audit command (but it wasn't fun)Re: point 2), because using the async/await pattern seems a bit difficult to do in audit, I opted to get a working solution that's a little quick-and-dirty. I'm using the
backoff
npm package to wait until instance variables on the batnode object say that the correct data is there.