Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Baseline redundancy branch #28

Merged
merged 16 commits into from
Mar 30, 2018
Merged

Baseline redundancy branch #28

merged 16 commits into from
Mar 30, 2018

Conversation

dylankb
Copy link
Member

@dylankb dylankb commented Mar 30, 2018

This is a bit of a rough branch, but still wanted to put it out there if others had thoughts.

  1. Calculates file data redundancy based on a baseline number
  2. Displays output of this test in the batchain terminal window for the audit command (but it wasn't fun)
  3. Tidying up code in a couple places
  4. Added instructions section to the readme for running a local demo

Re: point 2), because using the async/await pattern seems a bit difficult to do in audit, I opted to get a working solution that's a little quick-and-dirty. I'm using the backoff npm package to wait until instance variables on the batnode object say that the correct data is there.

@dylankb dylankb requested review from floalex and WilfredTA March 30, 2018 18:05
@WilfredTA
Copy link
Member

WilfredTA commented Mar 30, 2018

Can you integrate the changes into start.js? That way, when a user downloads the repo and starts up the program with start.js, audits will work way they do in your demo

Especially since the global batnode.js file is updated to reflect the new feature(s) you added, it would be good for the global start script to follow suit

@dylankb
Copy link
Member Author

dylankb commented Mar 30, 2018

Yeah, good catch that wasn't intentional. I added the logic to the start script as well.

@dylankb dylankb merged commit 4df7d72 into master Mar 30, 2018
@dylankb dylankb deleted the baseline-redundancy branch March 30, 2018 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants