Skip to content
This repository has been archived by the owner on May 24, 2021. It is now read-only.

Add options.dieOnError #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add options.dieOnError #25

wants to merge 1 commit into from

Conversation

jimthedev
Copy link

Fixes #23 by adding an option to not throw a plugin error.

@akreitals
Copy link

+1 any reason this hasn't been merged yet?

@lazd
Copy link
Owner

lazd commented Jul 19, 2014

+1 this makes a lot of sense. However, gulp-karma will be refactored into more of a helper soon. See #21 (comment) for details.

@lazd
Copy link
Owner

lazd commented Jul 23, 2014

@jimthedev and @akreitals, one question: Have you tried adding an error listener on the stream? That should stop it from dying.

@jimthedev
Copy link
Author

@lazd I think I did, and it would catch the error but still end the stream in certain cases where there was a parse error. With this said, it has been long time since I looked at this so I'm not 100% sure. I don't actually have the branch which used gulp-karma on my project anymore. We're currently using grunt still.

@akreitals
Copy link

@lazd Yeah sure did, but with no success unfortunately. In the interim I have simply implemented the dieOnError option while we wait for the Karma issue to be resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled exception when test fails
3 participants