-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GitHub actions #31
Comments
Hey, thanks for opening this issue and for your suggestion to improve this package. The library include only the integration tests, which deals with a real FTP server, so for testing you need an FTP account to be able to run the tests as intended. |
Hi, thanks for your reply. I think we can consider setting up fake FTP server and do integration tests during the GitHub action running, And it should be worked for the tests. If above recommendations are approved, I can work on that :). |
That sound good, FTP servers may have different implementation of the protocol specification, a fake FTP server is a good idea actually to put like a standard server that fully respect the spec (RFC 959 and extensions). I approve your recommendation, go a head. |
To make upcoming changes tested automatically, I think it can consider integrating the CI service.
I also recommend the GitHub action. If this issue is accepted, I will work on that :).
The text was updated successfully, but these errors were encountered: