Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GitHub actions #31

Closed
peter279k opened this issue Feb 7, 2022 · 3 comments · Fixed by #32
Closed

Adding GitHub actions #31

peter279k opened this issue Feb 7, 2022 · 3 comments · Fixed by #32

Comments

@peter279k
Copy link
Member

To make upcoming changes tested automatically, I think it can consider integrating the CI service.

I also recommend the GitHub action. If this issue is accepted, I will work on that :).

@AmraniCh
Copy link
Member

Hey, thanks for opening this issue and for your suggestion to improve this package.

The library include only the integration tests, which deals with a real FTP server, so for testing you need an FTP account to be able to run the tests as intended.

@peter279k
Copy link
Member Author

Hi, thanks for your reply. I think we can consider setting up fake FTP server and do integration tests during the GitHub action running, And it should be worked for the tests.

If above recommendations are approved, I can work on that :).

@AmraniCh
Copy link
Member

That sound good, FTP servers may have different implementation of the protocol specification, a fake FTP server is a good idea actually to put like a standard server that fully respect the spec (RFC 959 and extensions).

I approve your recommendation, go a head.

peter279k added a commit to open-source-contributions/php-ftp-client that referenced this issue Feb 15, 2022
peter279k added a commit to open-source-contributions/php-ftp-client that referenced this issue Feb 15, 2022
peter279k added a commit to open-source-contributions/php-ftp-client that referenced this issue Feb 15, 2022
peter279k added a commit to open-source-contributions/php-ftp-client that referenced this issue Feb 15, 2022
peter279k added a commit to open-source-contributions/php-ftp-client that referenced this issue Feb 15, 2022
peter279k added a commit to open-source-contributions/php-ftp-client that referenced this issue Feb 15, 2022
peter279k added a commit to open-source-contributions/php-ftp-client that referenced this issue Feb 16, 2022
@AmraniCh AmraniCh linked a pull request Feb 16, 2022 that will close this issue
peter279k added a commit to open-source-contributions/php-ftp-client that referenced this issue Feb 16, 2022
peter279k added a commit to open-source-contributions/php-ftp-client that referenced this issue Feb 17, 2022
peter279k added a commit to open-source-contributions/php-ftp-client that referenced this issue Feb 18, 2022
peter279k added a commit to open-source-contributions/php-ftp-client that referenced this issue Feb 18, 2022
peter279k added a commit to open-source-contributions/php-ftp-client that referenced this issue Feb 18, 2022
AmraniCh added a commit that referenced this issue Feb 18, 2022
@AmraniCh AmraniCh pinned this issue Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants