Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue #31 #32

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Conversation

peter279k
Copy link
Member

@peter279k peter279k commented Feb 16, 2022

Changed log

  • Closes issue#31.
  • After setting up the fake FTP server and GitHub action running, I found some errors and try to fix them.
  • The latest GitHub action log is available here.

tests/Dockerfile Outdated Show resolved Hide resolved
@AmraniCh AmraniCh linked an issue Feb 16, 2022 that may be closed by this pull request
@peter279k peter279k force-pushed the issue_#31 branch 3 times, most recently from 40ac876 to d52fe4c Compare February 18, 2022 02:50
@AmraniCh
Copy link
Member

I've created the ConnectionHelper class to avoid creating multiple FTP connections at the same time because FTP servers often have a maximum number of connections allowed for a unique user, I think now as long as we have the ability to configure our fake FTP server we should enable a high number of connections, removing the ConnectionHelper class and create a new connection in every integration test unit, tell me what you think!

@peter279k
Copy link
Member Author

peter279k commented Feb 18, 2022

I've created the ConnectionHelper class to avoid creating multiple FTP connections at the same time because FTP servers often have a maximum number of connections allowed for a unique user, I think now as long as we have the ability to configure our fake FTP server we should enable a high number of connections, removing the ConnectionHelper class and create a new connection in every integration test unit, tell me what you think!

It's the great idea, but I think it's another PR. This PR has contained many changes and I think I can wok for that on another PR after this current PR is merged :).

@peter279k
Copy link
Member Author

BTW, thanks for your patience to review all of changes on the PR. I appreciated that 🙏.

@AmraniCh
Copy link
Member

I've created the ConnectionHelper class to avoid creating multiple FTP connections at the same time because FTP servers often have a maximum number of connections allowed for a unique user, I think now as long as we have the ability to configure our fake FTP server we should enable a high number of connections, removing the ConnectionHelper class and create a new connection in every integration test unit, tell me what you think!

It's the great idea, but I think it's another PR. This PR has contained many changes and I think I can wok for that on another PR after this current PR is merged :).

Yeah! I was just letting you know what I was thinking. you should take some rest because you have done a lot of things here, I can handle this later.

BTW, thanks for your patience to review all of changes on the PR. I appreciated that 🙏.

Thanks to you also, I learn a lot from this PR and I really appreciate what you have done here.

BTW, Lazzard invites you to join us, if you have any questions let me know.

@peter279k
Copy link
Member Author

Thanks. I don't receive the invitation from the Lazzard. Please ensure the invitation is sent :).

@AmraniCh
Copy link
Member

Done!

@AmraniCh AmraniCh merged commit d910e62 into lazzard:master Feb 18, 2022
@peter279k peter279k deleted the issue_#31 branch February 19, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding GitHub actions
2 participants