-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue253 coverage (#557) #563
Conversation
* add options for startup and additional package loading
@FWuellhorst : Can you please correct the doctests, see https://app.travis-ci.com/github/lbl-srg/BuildingsPy/builds/271076330#L695 I already merged #562 into this branch to avoid a merge conflict. |
@mwetter I fixed the test and added to the Changes.txt. Another question: Using the latest buildingspy, you seemed to add a statement which prevents .mat files being copied to the tmp folder. We use .mat files for weather data in some regression tests in AixLib, leading to failing tests with no error indication, used "False". I had to use docker with port-forwarding to track down the issue. We could switch to txt or mos, but CombiTables support .mat. Why did you opt to not copy .mat files? |
@FWuellhorst : We excluded |
That makes sense. I converted them to .txt, which is either way better for git. Thanks! |
@FWuellhorst : FYI, this is now merged. |
This closes #253
add coverage script from Mans with changes based on review in Issue253 testexamplescoverage #315 Issue234 jmodelica regression #243
add unit-test and fix minor bug
Catch case for no examples