Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-5055: adjust data-model for connected snippet lists #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Nov 19, 2024

Overview

This PR slightly adjusts the data-model for connected snippet lists:

  • Rename snippet-lists JSON:API relationship defined on document-container to linked-snippet-lists for clarity
  • Add linked-snippet-lists JSON:API relationship to snippet data-model
  • Remove unused templates JSON:API relationship of snippet-list data-model

This PR also adds a migration which renames the ext:hasSnippetLists predicate to ext:linkedSnippetList for clarity.

connected issues and PRs:

GN-5055
lblod/frontend-reglementaire-bijlage#299

How to test/reproduce

  • Ensure the migration has run successfully
  • The /snippets and /document-containers JSON:API routes should now also provide (now mostly empty) linked-snippet-lists relationships

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • no new deprecations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant