I extracted dimension values into resource files #1151. #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(lbryio#1151) Because a lot of dimensions get reused, when I moved the dimensions file I used names like "large_1", "small_1", and "normal_1" for dimension values. I tried this to allow to cut down on repetitive values in the dimens file. "small" values range between 0dp and 15dp "normal" values range between 16dp to 119dp "large" values are anything over 120dp (the largest is 480dp)
|
For the next time, I suggest you to use a new branch for yout changes instead of commiting to your master branch |
|
Okay, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#1151)
Hi there!
Because a lot of dimensions get reused, when I moved the dimensions file I used names like "large_1", "small_1", and "normal_1" for dimension values.
I tried this to cut down on repetitive values in the dimens file.
"small" values range between 0dp and 15dp
"normal" values range between 16dp to 119dp
"large" values are anything over 120dp (the largest is 480dp)
[PS, I submitted an application to LBRY for an android engineer position on September 9, 2021. This PR is part of my application process.]
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: 1151
What is the current behavior?
What is the new behavior?
Other information