Enable the stdout/stderr logfile to be renamed and disabled. Configur…

…ation matches original burrow.out behavior. Resolves linkedin#57
lconnell · Nov 7, 2016 · cb4868f · cb4868f
1 parent 3726a11
commit cb4868f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/config.go b/config.go
@@ -37,6 +37,7 @@ type BurrowConfig struct {
 		ClientID       string `gcfg:"client-id"`
 		GroupBlacklist string `gcfg:"group-blacklist"`
 		GroupWhitelist string `gcfg:"group-whitelist"`
+		StdoutLogfile  string `gcfg:"stdout-logfile"`
 	}
 	Zookeeper struct {
 		Hosts    []string `gcfg:"hostname"`

diff --git a/docker-config/burrow.cfg b/docker-config/burrow.cfg
@@ -1,6 +1,7 @@
 [general]
 logconfig=/etc/burrow/logging.cfg
 group-blacklist=^(console-consumer-|python-kafka-consumer-).*$
+stdout-logfile=burrow.out
 
 [zookeeper]
 hostname=zookeeper

diff --git a/main.go b/main.go
@@ -60,8 +60,10 @@ func burrowMain() int {
 	createPidFile(appContext.Config.General.LogDir + "/" + appContext.Config.General.PIDFile)
 	defer removePidFile(appContext.Config.General.LogDir + "/" + appContext.Config.General.PIDFile)
 
-	// Set up stderr/stdout to go to a separate log file
-	openOutLog(appContext.Config.General.LogDir + "/burrow.out")
+	// Set up stderr/stdout to go to a separate log file, if enabled
+	if appContext.Config.General.StdoutLogfile != "" {
+		openOutLog(appContext.Config.General.LogDir + "/" + appContext.Config.General.StdoutLogfile)
+	}
 	fmt.Println("Started Burrow at", time.Now().Format("January 2, 2006 at 3:04pm (MST)"))
 
 	// If a logging config is specified, replace the existing loggers