Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Button Styles in index.html and favs.html #87

Merged

Conversation

AdityaGahukar
Copy link
Contributor

Fixes #86

Description

This PR addresses the inconsistency in the styling of the Login and Upload GIF buttons present in index.html and favs.html. The goal is to move inline styles into the CSS file (styles.css) to ensure uniformity and maintainability across the application.

Changes Made

  • Updated CSS:

    • Moved font-family and font-weight properties from inline styles to the .secondary-btn class in styles.css.
    • Added a new class .upload-btn to handle the margin-left for the Upload GIF button.
  • Modified HTML:

    • Removed inline styles for both buttons in index.html and favs.html.
    • Applied the new .upload-btn class to the Upload GIF button to maintain consistent margins.

Files Changed

  • styles.css
  • index.html
  • favs.html

Screenshots

image
image

@lcrojano lcrojano added good first issue Good for newcomers hacktoberfest-accepted hacktoberfest-accepted hacktoberfest labels Oct 25, 2024
@lcrojano lcrojano merged commit 4106d6a into lcrojano:main Oct 25, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest hacktoberfest-accepted hacktoberfest-accepted
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Enhancement] Inconsistent CSS for Login and Upload GIF Buttons in index.html and favs.html
2 participants