Update ApRESDefs.py #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of a remote_load arg, always try remotely loading if local file load fails using a try-except statement. This can be propagated through all classes to potentially remove the need for the remote_load arg. I find it very easy to forget that default remote_load=False means that the code will fail with a type error.
replaced datafile with self.Filename as intended
I think this should fix the datafile reference if it doesn't exist
just removed the datafile check, which is likely unnecessary since all bad filepaths seem to cause an error
|
This sounds like a good idea. Thanks for working on it. It does seem like we may run into conflicts as I continue working on #20, as both involve changes to ApRESDefs.py, but I am not really sure how to avoid that. Any thoughts? |
|
Maybe this line does what we want here: https://github.com/leap-stc/LEAP-bootcamps/blob/2a00e294a2cb91c21070bf18ee1051fd4b5d0d0f/Codes/Day2/utils.py#L15 |
|
I just merged a PR that should do what this was aiming to do: #53 Let me know if this isnt working as you originally envisioned or you think it can be improved and we can work on improving it! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of a remote_load arg, always try remotely loading if local file load fails using a try-except statement. This can be propagated through all classes to potentially remove the need for the remote_load arg. I find it very easy to forget that default remote_load=False means that the code will fail with a type error.