Change loading code #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
next step is to get it working in attended mode.
Deleted all unused code. A lot could be removed because the bas-apres code replaces it. Also adds many new test which get coverage up to >95%
these will be overwritten when we build in actions
add tests and move chirp_time dtype correction, remove unused arguments, sort bug in attended load using from_dats/load()
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big overhaul of the code used to load dat files.
Instead of using the code originally written by Keith Nicholls to load the header and chirps, it will now use a package called bas-apres. This results in a lot of code from xapres being deleted and overall significant simplification.
For example, the new code has only two functions that are specific to unattended or attended, whereas before we have a couple of levels on each side.
The structure in load,from_dats is now as follows
all_bursts_in_dat_to_xarray-->load_allfor unattendedand
all_bursts_at_waypoint_to_xarray-->load_allfor attended.all_bursts_in_dat_to_xarrayandall_bursts_at_waypoint_to_xarrayboth call a number of other smaller function includingsubset_bursts_to_processandheader_cleaningand
load_allcalls a few other likeis_this_a_remote_load,subset_filesandlist_filesThis PR also simplifies the dependencies and adds a number of tests, which brings the coverage up to 99%.
It also adds my fork of bas-apres as a submodule.
I pulled the changes that I merged form the docs branch, so now this branch also builds the latest version of the docs.