Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added troubleshoot section #3

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

oiricaud
Copy link

@oiricaud oiricaud commented Jul 24, 2020

Pull request summary

As I was following the great guide there was just a piece of information missing. How do you update the CRD if you MCM cluster does not have the Github type enum? Added this in the pull request.

Also the nginx image that was being used was run as root and was causing issues, resolved this as well.

Copy link
Owner

@ldesrosi ldesrosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the PR. It is much appreciated.

I see you moved the nginx deployment YAML files within this repo but the 00-channel.yaml still points to the other repo (https://github.com/ldesrosi/cp4mcm-nginx-app.git).

Was your intention to have both App and MCM Yaml contained in this repo? If so we need to adjust the 00-channel.yaml github url.

A minor point: I see you removed the end of line for the files within the /resources folder. While not a huge deal, the implication is that anyone that cat those files will have their command lines appended to that last line instead of being on it's separate line.

@oiricaud
Copy link
Author

oiricaud commented Jul 28, 2020

Sure i'll fix those issues! Thanks for the feedback.

The reason I forked this is because I will be using this microservices to deployed them via MCM https://github.com/ibm-garage-ref-storefront

More specifically, I will be using these deployments from here https://github.com/ibm-garage-ref-storefront/gitops-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants