Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build task should actually build the application, not publish #13

Merged
merged 18 commits into from
Aug 23, 2024
Merged

Build task should actually build the application, not publish #13

merged 18 commits into from
Aug 23, 2024

Conversation

Thodor12
Copy link
Contributor

Build was implemented completely wrong

@Thodor12 Thodor12 mentioned this pull request Aug 19, 2024
Closed
marchermans
marchermans requested changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@marchermans marchermans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PRs changes are not inline with the goal of the relevant action, that is to build, test and publish its results to github packages so that they are accessible.

@Thodor12 Thodor12 mentioned this pull request Aug 19, 2024
Closed
5 tasks
@Thodor12 Thodor12 requested a review from marchermans August 19, 2024 20:02
marchermans
marchermans requested changes Aug 20, 2024
View reviewed changes
.github/workflows/gradle.prerelease.yaml Outdated Show resolved Hide resolved
.github/workflows/gradle.build.yaml Outdated Show resolved Hide resolved
@Thodor12 Thodor12 requested a review from marchermans August 20, 2024 13:11
marchermans
marchermans requested changes Aug 23, 2024
View reviewed changes
.github/workflows/gradle.build.yaml Outdated Show resolved Hide resolved
.github/workflows/gradle.build.yaml Show resolved Hide resolved
.github/workflows/gradle.build.yaml Outdated Show resolved Hide resolved
.github/workflows/gradle.prerelease.yaml Outdated Show resolved Hide resolved
@marchermans marchermans merged commit 7ecd808 into ldtteam:main Aug 23, 2024
1 check passed
@Thodor12 Thodor12 deleted the patch-3 branch August 23, 2024 20:41
@Thodor12 Thodor12 mentioned this pull request Aug 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchermans marchermans marchermans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thodor12 @marchermans