Some additional solid checks

[Raycoms]

Closes #712
Closes #

Changes proposed in this pull request

• Check if not replaceable/no collision for solidness too

Testing

• Yes I tested this before submitting it.
• I also did a multiplayer test.

Review please

[MotionlessTrain]

I assume this PR will close the issue, rather than itself? 😛

[Raycoms]

I assume this PR will close the issue, rather than itself? 😛

Oui, I thought the issue was on minecolonies repo =D

[MotionlessTrain]

I mean, the link in the “closes” section mentions this PR, rather than the issue

[Raycoms]

I mean, the link in the “closes” section mentions this PR, rather than the issue

oh, one number off xD

[Nightenom]

canBeReplaced makes somewhat sense to me
not sure if hasCollision is good idea

[Nightenom]

do we need this? i mean if it isnt avaiable through sth else

[Raycoms]

it's the most efficient way to access it nicely.

[Raycoms]

canBeReplaced makes somewhat sense to me not sure if hasCollision is good idea

Blocks that have no collision aren't solid for our intents and purposes. (e.g. players/entities) can't stand on them.

[Nightenom]

This aint for "players/entities can stand of them" and shouldnt be used as such, if we're using it for this then we should have more definitions of solid
This solid is for building, ie.: if i place it at 0,0,0 will it under all conditions stay at 0,0,0 unchanged? (unchanged wrt. blockstate and blockentity serialization data)

[Raycoms]

This aint for "players/entities can stand of them" and shouldnt be used as such, if we're using it for this then we should have more definitions of solid This solid is for building, ie.: if i place it at 0,0,0 will it under all conditions stay at 0,0,0 unchanged? (unchanged wrt. blockstate and blockentity serialization data)

It's not a "floating block placeholder" it's a solid placeholder. A block that has no collision block is not solid.

[Nightenom]

This changes I've done was for purpose of building being less error-prone, imho solid placeholders should really be tightened to sth like tag (and not to this rather weak check for building iterator)