Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several fixes for bottles and mod compilationn errors #10126

Merged
merged 3 commits into from
Aug 18, 2024

Conversation

Thodor12
Copy link
Contributor

@Thodor12 Thodor12 commented Aug 18, 2024

Closes discord report always losing 1 bottle in stack of bottles

Changes proposed in this pull request:

  • Filled bottles could be immediately filled with another liquid, without requiring an empty bottle
  • Stacks got shrunk before a new item was placed, causing last items in the stack to be voided (both for water and milk)
  • Fix errors that prevented 1.20.1 from compiling due to updates in OPC

[X] Yes I tested this before submitting it.
[ ] I also did a multiplayer test.

Review please

@Raycoms Raycoms merged commit 5fd25d6 into ldtteam:version/main Aug 18, 2024
1 check passed
@Thodor12 Thodor12 deleted the fix/bottle_usage branch August 18, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants