Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.1 should use JDK 17 to compile #10127

Closed
wants to merge 4 commits into from
Closed

1.20.1 should use JDK 17 to compile #10127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5f0d63
Update release.yml
Thodor12 Aug 18, 2024
c68fb2e
Update build.yaml
Thodor12 Aug 18, 2024
f1261d7
Update release.yml
Thodor12 Aug 18, 2024
d59b8f3
Update release.yml
Thodor12 Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
release:
uses: ldtteam/operapublicacreator/.github/workflows/gradle.publish.yaml@main
with:
java: 21
java: 17
secrets:
CROWDIN_API_KEY: ${{ secrets.CROWDIN_API_KEY }}
GRADLE_ENCRYPTION_KEY: ${{ secrets.GRADLE_ENCRYPTION_KEY }}
GRADLE_ENCRYPTION_KEY: ${{ secrets.GRADLE_ENCRYPTION_KEY }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readd newline please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#blame-github

Copy link
Member

@Nightenom Nightenom Aug 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

he added them :D (they werent there before)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github display of that is confusing =D

5 changes: 3 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,13 @@ jobs:
release:
uses: ldtteam/operapublicacreator/.github/workflows/gradle.publish.yaml@main
with:
java: 21
java: 17
curse_release_type: ${{ contains(github.ref, 'release') && 'release' || 'beta' }}
secrets:
DISCORD_WEBHOOK: ${{ secrets.DISCORD_WEBHOOK }}
MAVEN_USER: ${{ secrets.MAVEN_USER }}
MAVEN_PASSWORD: ${{ secrets.MAVEN_PASSWORD }}
CROWDIN_API_KEY: ${{ secrets.CROWDIN_API_KEY }}
CURSE_API_KEY: ${{ secrets.CURSE_API_KEY }}
GRADLE_ENCRYPTION_KEY: ${{ secrets.GRADLE_ENCRYPTION_KEY }}
GRADLE_ENCRYPTION_KEY: ${{ secrets.GRADLE_ENCRYPTION_KEY }}