Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix banner crashing client when copying blank vanilia banner and desync in multiplayer #10500

Merged
merged 12 commits into from
Dec 8, 2024
Merged

Fix banner crashing client when copying blank vanilia banner and desync in multiplayer #10500

merged 12 commits into from
Dec 8, 2024

Conversation

cylian914
Copy link
Contributor

Changes proposed in this pull request

  • Fix banner crashing client on banner that didn't have tags (aka blank patterns)
  • Fix server not copying but client did, causing a desync
  • add a explanation on how to copy banner's patterns

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

Thodor12
Thodor12 previously approved these changes Dec 4, 2024
View reviewed changes
Raycoms
Raycoms reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@Raycoms Raycoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission. A small formatting thing is missing still. And an important question: Did you test this in singleplayer/multiplayer?

src/main/java/com/minecolonies/core/items/ItemColonyFlagBanner.java Outdated Show resolved Hide resolved
@cylian914
Copy link
Contributor Author

cylian914 commented Dec 4, 2024 •
edited
Loading

yes i did tested it in multiplayer and singleplayer

@Raycoms Raycoms merged commit 9700ea5 into ldtteam:version/main Dec 8, 2024
5 checks passed
@cylian914 cylian914 deleted the banner-fix branch December 24, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MotionlessTrain MotionlessTrain MotionlessTrain left review comments

@someaddons someaddons someaddons approved these changes

@Raycoms Raycoms Raycoms approved these changes

@Thodor12 Thodor12 Thodor12 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cylian914 @Raycoms @MotionlessTrain @Thodor12 @someaddons